-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTPS-only to privacy.network #8830
Conversation
@Rob--W Can you review this? :) |
webextensions/api/privacy.json
Outdated
@@ -75,6 +75,30 @@ | |||
} | |||
} | |||
} | |||
}, | |||
"HTTPS-only": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
httpsOnlyMode is the name of the property.
webextensions/api/privacy.json
Outdated
"version_added": "84" | ||
}, | ||
"firefox_android": { | ||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is also available on Firefox for Android (but there is no visible UI to enable it, so it's currently always "never").
(On all platforms the setting is read-only)
(On Fenix Nightly users can visit about:config to toggle the underlying preferences, but that's not really an expected scenario)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the note at Android and consider it approved.
webextensions/api/privacy.json
Outdated
}, | ||
"firefox_android": { | ||
"version_added": "84", | ||
"notes": "There is no visible UI to enable this feature for Firefox for Android, so it's currently always `never`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note doesn't need to be there.
Thanks @Rob--W! |
@chrisdavidmills Hey there! Who on the MDN team should I tag for review/approval for BCD prs? :) |
@caitmuenster usually they are picked up before too long. If one is taking a bit of time, then I'd suggest pinging @ddbeck or @Elchi3 . |
Merged; the BCD data can follow. |
…icture * upstream/master: (1123 commits) Remove Chromium 89 from String.at / Array.at / TypedArray.at (mdn#8869) Add worker_support info for CacheStorage (mdn#8783) Remove several needless "Enabled by default" notes (mdn#8899) Add HTML global attribute nonce (mdn#8764) api.Navigator.vibrate - Firefox for Android doesn't vibrate (mdn#7172) Mark MediaSource's onsourceclose as not supported in Firefox (mdn#8881) Update Florian's ownership (mdn#8893) Mention fix for Chrome's broken PDF loading (mdn#8867) Fill out Chrome data for html.elements.source.{sizes,srcset} (mdn#8889) Weekly data release for 2021-01-28 Add text-decoration-thickness for Opera 73+ (mdn#8872) Update :is and :where pseudo-classes for Chrome (mdn#7375) Add note re Safari <9 partial srcset/sizes support (mdn#7353) Update data for when href (not xlink:href) can be used in SVG (mdn#6603) Add top-level await (mdn#8807) TouchList: Add Safari Desktop and Safari iOS versions (mdn#8848) Update Firefox versions to account for Firefox 85 release (mdn#8864) Fix page_action.show_matches support for Android (mdn#8844) Update Safari support for devicechange_event (mdn#8863) Add HTTPS-only to privacy.network (mdn#8830) ...
…yMode This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `privacy` Web Extensions api properties. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD. Commit/PR Adding the Feature: mdn#8830
Despite it being added to the compatibility data in mdn#8830, in reality it does not exist on Chromium browsers. Co-authored-by: Rob Wu <[email protected]>
* Update Chromium data for privacy Web Extensions api properties The privacy API, at the time already containing both services.alternateErrorPagesEnabled and services.autofillEnabled, was moved out of the experimental status in https://source.chromium.org/chromium/chromium/src/+/607e6522f841933e0d3130c09d33207876850948, which according to https://source.chromium.org/chromium/chromium/src/+/607e6522f841933e0d3130c09d33207876850948:chrome/VERSION was Chrome 18. * Update Chromium data for privacy Web Extensions api property httpsOnlyMode This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `privacy` Web Extensions api properties. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD. Commit/PR Adding the Feature: #8830 * Mirror Edge data in the Web Extensions privacy API * Properly mirror Edge data in Web Extensions privacy API * httpsOnlyMode not in Chromium Web Extensions privacy API Despite it being added to the compatibility data in #8830, in reality it does not exist on Chromium browsers. Co-authored-by: Rob Wu <[email protected]> --------- Co-authored-by: Rob Wu <[email protected]>
Adds HTTPS-only to privacy.network WebExtensions API, per https://bugzilla.mozilla.org/show_bug.cgi?id=1678306. Partial fix for mdn/content#289.