Pypy3 #1
Closed
Pypy3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails to build, missing |
Which introduced a new set of problems to work around.
This reverts commit e218cc8. It typically caused CI to run twice for all PRs - one for the branch and one for the PR itself.
…ll (mhammond#1871) Do a separate search for the required DLLs and use this to create a more specific and helpful warning message. Change logic to not insist both DLLs be found in the same folder.
mattip
force-pushed
the
pypy3
branch
2 times, most recently
from
5d5cf7b
to
c90ae7e
Compare
* Rename and cleanup old string conversion functions now Python 2 support isn't required and to make "String" less ambiguous. * Remove dead code that was only used when UNICODE was not defined, because it is defined everywhere.
Signed-off-by: Tim Gates <[email protected]>
… for variable version number (mhammond#2089)
Avasam
reviewed
Mar 12, 2024
win32/src/PyUnicode.cpp
Outdated
| #if defined(PYPY_VERSION_NUM) && PYPY_VERSION_NUM < 0x07030b00 | ||
| stringObject = tempObject = | ||
| PyUnicode_EncodeMBCS(PyUnicode_AS_UNICODE(stringObject), PyUnicode_GET_SIZE(stringObject), NULL); | ||
| #else | ||
| // PyUnicode_EncodeMBCS was removed in Py 3.11. | ||
| PyObject *unicode = PyUnicode_FromWideChar(PyUnicode_AS_UNICODE(stringObject), -1); | ||
| if (unicode == NULL) | ||
| return FALSE; | ||
| stringObject = tempObject = PyUnicode_EncodeCodePage(CP_ACP, unicode, NULL); |
There was a problem hiding this comment.
So you know, this was removed in mhammond#1860 , you might wanna pull upstream again
Avasam
reviewed
Mar 12, 2024
setup.py
Outdated
| @@ -1004,7 +1017,7 @@ def get_ext_filename(self, name): | |||
| return "win32\\pythonservice" + extra_exe | |||
| elif name.endswith("pythonwin.Pythonwin"): | |||
| return "pythonwin\\Pythonwin" + extra_exe | |||
| return name.replace(".", "\\") + ".pyd" | |||
| return name.replace(".", "\\") + EXT_SUFFIX | |||
There was a problem hiding this comment.
This isn't equivalent
>>> import sysconfig
>>> sysconfig.get_config_var("EXT_SUFFIX")
'.cp39-win_amd64.pyd'
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.