Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a utility for finding test fixtures that allows it to not exist i… #1880

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

mhammond
Copy link
Owner

…n installed dirs

@mhammond
Copy link
Owner Author

@kxrob pointed out in #1863 that finding fixtures was a footgun, so I improved it and split it out. Combined with #1879, in CI we previously saw:

SKIPPED: 13 tests - (-2147221005, 'Invalid class string', None, None)
SKIPPED: 3 tests - (-2005401480, 'OLE error 0x88780078', None, None)
SKIPPED: 1 tests - Can't find test .wav file to play

But now it does find the test file, but can't initialize a sound device (DSERR_NODRIVER), so skips like most other ds tests.

SKIPPED: 13 tests - (-2147221005, 'Invalid class string', None, None)
SKIPPED: 4 tests - (-2005401480, 'OLE error 0x88780078', None, None)

(I've split this from #1879 to ensure it works OK when tests are run directly from the installed dir)

@mhammond mhammond requested a review from kxrob May 15, 2022 08:23
@mhammond mhammond merged commit a2bf93d into main Jul 1, 2022
@mhammond mhammond deleted the test-fixtures branch July 1, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant