Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change mbcs encoding to utf-8 in com/win32com/client #2097

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Change mbcs encoding to utf-8 in com/win32com/client #2097

merged 4 commits into from
Nov 1, 2023

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Aug 9, 2023 •
edited
Loading

#1990 (comment)

[...] I suspect this is wrong now - when this file is being read I believe it will be assumed utf-8. Ditto the mbcs reference in build.py

- @mhammond

This changes more than what the initial comment mentioned, but I figured may as well review all usages of it. Even if we end up reverting because the needed changes would be too big or wrong.

  • Changed mbcs to utf-8 in com/win32com/client
  • Removed unused mbcs encoding code in Pythonwin/pywin/

Avasam
Avasam commented Aug 9, 2023
View reviewed changes
win32/Demos/win32gui_dialog.py Outdated Show resolved Hide resolved
@Avasam Avasam mentioned this pull request Aug 9, 2023
Merged
mhammond
mhammond requested changes Aug 10, 2023
View reviewed changes
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now we should only change the COM functions - where we generate a .py file. Most of the other places changed are quite possibly wrong as it's not Python file IO consuming the bytes.

win32/Demos/win32gui_dialog.py Outdated Show resolved Hide resolved
Pythonwin/pywin/__init__.py Outdated Show resolved Hide resolved
Pythonwin/pywin/tools/hierlist.py Outdated Show resolved Hide resolved
isapi/install.py Outdated Show resolved Hide resolved
@Avasam Avasam changed the title Change mbcs encoding to utf-8 Change mbcs encoding to utf-8 in com/win32com/client Aug 10, 2023
@Avasam Avasam requested a review from mhammond August 10, 2023 17:14
mhammond
mhammond approved these changes Aug 10, 2023
View reviewed changes
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Avasam
Copy link
Collaborator Author

Avasam commented Nov 1, 2023

Thanks

Bumping this PR. This has been approved but not merged @mhammond

@mhammond mhammond merged commit 309a8b0 into mhammond:main Nov 1, 2023
@Avasam Avasam deleted the mbcs-encoding-to-utf8 branch November 1, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond mhammond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avasam @mhammond