Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Notification settings not transferred on room upgrade #5295

Open
anoadragon453 opened this issue May 30, 2019 · 4 comments
Open

Notification settings not transferred on room upgrade #5295

anoadragon453 opened this issue May 30, 2019 · 4 comments
Assignees
@anoadragon453
Labels
A-Push Issues related to push/notifications A-Room-Upgrades O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@anoadragon453
Copy link
Member

Just had an instance of notification settings not transferring on room upgrade. Note to self to check hs logs.

element-hq/element-web#9905
@anoadragon453 anoadragon453 self-assigned this May 30, 2019
@turt2live
Copy link
Member

What happened to #4597 ?

@anoadragon453
Copy link
Member Author

There seems to be an edge case.

@neilisfragile neilisfragile added z-bug (Deprecated Label) A-Room-Upgrades z-p2 (Deprecated Label) labels Jun 7, 2019
@turt2live turt2live mentioned this issue Jun 13, 2019
Closed
@turt2live turt2live mentioned this issue Jul 30, 2019
Closed
@neilisfragile neilisfragile added p1 and removed z-p2 (Deprecated Label) labels Jul 31, 2019
@turt2live turt2live mentioned this issue Aug 5, 2019
Open
@anoadragon453 anoadragon453 mentioned this issue Oct 2, 2019
Merged
richvdh pushed a commit that referenced this issue Oct 10, 2019
@anoadragon453 @richvdh
Move tag/push rules room upgrade checking ealier (#6155)
da815c1 
It turns out that _local_membership_update doesn't run when you join a new, remote room. It only runs if you're joining a room that your server already knows about. This would explain #4703 and #5295 and why the transfer would work in testing and some rooms, but not others. This would especially hit single-user homeservers.

The check has been moved to right after the room has been joined, and works much more reliably. (Though it may still be a bit awkward of a place).
@hawkowl
Copy link
Contributor

hawkowl commented Oct 10, 2019

Fixed by #6155

@hawkowl hawkowl closed this as completed Oct 10, 2019
@turt2live turt2live mentioned this issue Jan 9, 2020
Closed
@turt2live
Copy link
Member

This is empirically still happening to some people: element-hq/element-web#11803

@turt2live turt2live reopened this Jan 9, 2020
@DMRobertson DMRobertson added A-Push Issues related to push/notifications S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed z-bug (Deprecated Label) z-p1 labels Aug 25, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anoadragon453 anoadragon453

Labels
A-Push Issues related to push/notifications A-Room-Upgrades O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@neilisfragile @turt2live @anoadragon453 @hawkowl @DMRobertson