Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Catch new invalid user name error #92

Merged
merged 2 commits into from
Jan 15, 2016
Merged

Catch new invalid user name error #92

merged 2 commits into from
Jan 15, 2016

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 14, 2016

@dbkr
Copy link
Member Author

dbkr commented Jan 14, 2016

Helps with element-hq/element-web#512

@kegsay
Copy link
Member

kegsay commented Jan 15, 2016

Looking at those other PRs you've got an inconsistency. Whilst Synapse and this PR look for M_INVALID_USER_NAME, the spec sez it is M_INVALID_USERNAME.

@kegsay
Copy link
Member

kegsay commented Jan 15, 2016

LGTM aside from matrix-doc inconsistency.

@dbkr
Copy link
Member Author

dbkr commented Jan 15, 2016

Yeah, it started out as M_INVALID_USER_NAME but then was changed. I updated all three branches and re-merged the doc one I'd merged.

@kegsay
Copy link
Member

kegsay commented Jan 15, 2016

ok LGTM!

dbkr added a commit that referenced this pull request Jan 15, 2016
@dbkr
Merge pull request #92 from matrix-org/invalid_user_name
80c2361 
Catch new invalid user name error
@dbkr dbkr merged commit 80c2361 into develop Jan 15, 2016
krombel pushed a commit to krombel/matrix-react-sdk that referenced this pull request May 16, 2017
@MTRNord
Merge pull request matrix-org#92 from krombel/fix_typo
8bbafd8 
fix typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kegsay kegsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @kegsay