Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apparently username validation fails at signup (or invite?) and allows spaces(?) #512

Closed
ara4n opened this issue Dec 13, 2015 · 7 comments
Closed

Apparently username validation fails at signup (or invite?) and allows spaces(?) #512

ara4n opened this issue Dec 13, 2015 · 7 comments
Assignees
@dbkr
Labels
P2 T-Defect
Milestone
v0 - Friendly Beta

Comments

@ara4n
Copy link
Member

ara4n commented Dec 13, 2015

No description provided.

@ara4n ara4n added this to the v0 milestone Dec 13, 2015
@kegsay
Copy link
Contributor

kegsay commented Jan 13, 2016

I suspect this is at invite stage. Synapse really should validate the stuff clients pass it... I am unconvinced that this is something Vector specifically should fix (other than providing an immediate fonx).

@ara4n
Copy link
Member Author

ara4n commented Jan 13, 2016

Absolutely agreed we need serverside validation, but we also need clientside validation.

@ara4n
Copy link
Member Author

ara4n commented Jan 13, 2016

Complicated by spec-1 still being open. For now, let's mandate that uri_encode(username) === username

@ara4n
Copy link
Member Author

ara4n commented Jan 13, 2016

...and no colons!

@dbkr
Copy link
Member

dbkr commented Jan 14, 2016

Do we actually need client side validation or would it be enough in this case to actually display the right error when the server rejects us?

@ara4n
Copy link
Member Author

ara4n commented Jan 14, 2016

happy to let the server validate for now, although please drop prio rather than close.

@dbkr
Copy link
Member

dbkr commented Jan 14, 2016

OK

This was referenced Jan 14, 2016
Merged
Merged
@dbkr dbkr closed this as completed Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
P2 T-Defect
Projects
None yet
Milestone
v0 - Friendly Beta
Development

No branches or pull requests
3 participants
@dbkr @ara4n @kegsay