This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Do (more) client side validation of registration parameters. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.props.onError(errCode); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
We're removing the checks from "submit" time and moving them to be recalculated on the fly which is cool, but we then need to check in onSubmit that there are no invalid fields. I don't see this check being made, so what's stopping me from just hitting Register with invalid fields?
There was a problem hiding this comment.
The server will reject it anyway (don't say we didn't warn you!) but yes, point - this is easy to do.
|
LGTM aside from comment. |
…fine it & fix some error codes.
|
Fixed. Changes are probably big enough to warrant a ptal. |
|
LGTM |
dbkr
added a commit
that referenced
this pull request
Jan 15, 2016
Do (more) client side validation of registration parameters.
MTRNord
added a commit
to krombel/matrix-react-sdk
that referenced
this pull request
May 16, 2017
…matrix-react-sdk-strings Update from Weblate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#512