Add an error code for invalid user names. #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,6 +100,7 @@ paths: | |||
| Part of the request was invalid. This may include one of the following error codes: | |||
|
|
|||
| * ``M_USER_IN_USE`` : The desired user ID is already taken. | |||
| * ``M_INVALID_USER_NAME`` : The desired user ID is not a valid user name. | |||
There was a problem hiding this comment.
The other USER error refers to user IDs just as USER (M_USER_IN_USE), maybe use the same to be consistent?
There was a problem hiding this comment.
Asked to about this to see what others though, suggestion seems to be M_INVALID_USERNAME to match the parameter to the API. Thoughts?
There was a problem hiding this comment.
Works for me :)
(I can also live with it as it is)
(Also, it's a shame we're so inconsistent with our names everywhere)
|
LGTM, one suggestion |
|
Still LGTM :) |
dbkr
added a commit
that referenced
this pull request
Jan 15, 2016
Add an error code for invalid user names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.