-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when roomSummary is nil #1731
Fix crash when roomSummary is nil #1731
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1731 +/- ##
===========================================
- Coverage 37.53% 37.44% -0.09%
===========================================
Files 612 612
Lines 96235 96266 +31
Branches 41603 41613 +10
===========================================
- Hits 36119 36046 -73
- Misses 59041 59163 +122
+ Partials 1075 1057 -18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for the inline comments
MatrixSDK/Data/RoomList/Common/MXBreadcrumbsRoomListDataFetcher.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 👍
This PR fixes the following crash: element-hq/element-ios#7403