App crashes with SIGABRT when typing any letter in search

[matrixuser0]

Steps to reproduce

1. In main screen, enter search field
2. Type any letter

(Clearing cache beforehand in settings doesn't change anything)

This is on a custom homeserver, participating in 100+ rooms.

Outcome

What did you expect?

I expect search to work, like it did before the update to 1.10.3

What happened instead?

App crashes with SIGABRT in MXBreadcrumbsRoomListDataFetcher.refresh(). Stack trace:

MXBreadcrumbsRoomListDataFetcher.refresh() (MatrixSDK + 0x2260e0)
MXBreadcrumbsRoomListDataFetcher.refresh() (MatrixSDK + 0x22592c)
@objc MXBreadcrumbsRoomListDataFetcher.refresh() (MatrixSDK + 0x226100)
MXRoomListDataFetchOptions.filterOptions.setter MatrixSDK + 0x2caa80
...
-[UISearchController _ios_searchBar:textDidChange:programatically:] UIKitCore + 0xd7e634
...

(I can send full IPS if needed, but would like to avoid it in case it contains any sensitive info - there are no system logs).

From my (uninformed) analysis, this is most likely a regression in matrix-org/matrix-ios-sdk@9390c13#diff-6984b54f99a1423390f0aebf811e6c9edbad463249ab6248437eaa82b630fbd6L94, where roomSummary(...) returns nil in guard let displayname = session?.roomSummary(withRoomId: roomId).displayname. Should be roomSummary(withRoomId: roomId)?.displayname maybe. I'm not really familiar with Swift however, and don't know if roomSummary(...) should ever be able to return nil

Your phone model

iPhone 12

Operating system version

iOS 16.3.1

Application version

Element version 1.10.3

Homeserver

custom private Synapse

Will you send logs?

No

[matrixuser0]

If you consider the proposed fix as valid, I created a PR for it: matrix-org/matrix-ios-sdk#1729 If not, feel free to close.

This is a time sensitive issue for me personally since it prevents me from navigating our company's home server effectively.

[Velin92]

I have seen the PR that looks great, added a comment to it, if you could add the sign off and the changelog I will approve it!