Remove is_rare_earth_metal from ElementBase (periodic_table.py)
#4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdewasseigeosium
force-pushed
the
jdewasseige/rm_deprecated_is_rare_earth_metal
branch
from
6eec3ef to
25f796e
Compare
|
this will close #4243 |
|
It would be great if this could be merged. Currently, all our imports from pymatgen where composition is used lead to failures. Additionally, a new release would be very helpful. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated
is_rare_earth_metalfromElementBasein periodic_table.py.This function was deprecated here since end of May 2024. Confirming it’s not used anymore elsewhere in the code & I removed it from the docs as well. I just removed one line from docs/pymatgen.md but it seems like git interpreted it as more.
Major changes:
is_rare_earth_metalfromElementBaseChecklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)Tip: Install
pre-commithooks to auto-check types and linting before every commit: