Skip to content

Commit

Permalink
Remove is_rare_earth_metal from ElementBase (periodic_table.py) (#…
Browse files Browse the repository at this point in the history
…4242)

* Remove is_rare_earth_metal from periodic_table.py

* Rm deprecated from monty

* Rm is_rare_earth_metal from docs/pymatgen.md
  • Loading branch information
jdewasseigeosium authored Jan 7, 2025
1 parent 9b4623d commit e2baa68
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
1 change: 0 additions & 1 deletion docs/pymatgen.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions src/pymatgen/core/periodic_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from typing import TYPE_CHECKING, overload

import numpy as np
from monty.dev import deprecated
from monty.json import MSONable

from pymatgen.core.units import SUPPORTED_UNIT_NAMES, FloatWithUnit, Ha_to_eV, Length, Mass, Unit
Expand Down Expand Up @@ -754,19 +753,6 @@ def is_rare_earth(self) -> bool:
"""
return self.is_lanthanoid or self.is_actinoid or self.symbol in {"Sc", "Y"}

@property
@deprecated(
is_rare_earth,
message="is_rare_earth is corrected to include Y and Sc.",
deadline=(2025, 1, 1),
)
def is_rare_earth_metal(self) -> bool:
"""True if element is a rare earth metal, Lanthanides (La) series and Actinides (Ac) series.
This property is Deprecated, and scheduled for removal after 2025-01-01.
"""
return self.is_lanthanoid or self.is_actinoid

@property
def is_metal(self) -> bool:
"""True if is a metal."""
Expand Down

0 comments on commit e2baa68

Please sign in to comment.