Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_rare_earth_metal from ElementBase (periodic_table.py) #4242

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Remove is_rare_earth_metal from ElementBase (periodic_table.py) #4242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25f796e
Remove is_rare_earth_metal from periodic_table.py
jdewasseigeosium Jan 2, 2025
aade053
Rm deprecated from monty
jdewasseigeosium Jan 2, 2025
30f03a2
Rm is_rare_earth_metal from docs/pymatgen.md
jdewasseigeosium Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/pymatgen.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions src/pymatgen/core/periodic_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from typing import TYPE_CHECKING, overload

import numpy as np
from monty.dev import deprecated
from monty.json import MSONable

from pymatgen.core.units import SUPPORTED_UNIT_NAMES, FloatWithUnit, Ha_to_eV, Length, Mass, Unit
Expand Down Expand Up @@ -754,19 +753,6 @@ def is_rare_earth(self) -> bool:
"""
return self.is_lanthanoid or self.is_actinoid or self.symbol in {"Sc", "Y"}

@property
@deprecated(
is_rare_earth,
message="is_rare_earth is corrected to include Y and Sc.",
deadline=(2025, 1, 1),
)
def is_rare_earth_metal(self) -> bool:
"""True if element is a rare earth metal, Lanthanides (La) series and Actinides (Ac) series.

This property is Deprecated, and scheduled for removal after 2025-01-01.
"""
return self.is_lanthanoid or self.is_actinoid

@property
def is_metal(self) -> bool:
"""True if is a metal."""
Expand Down