Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement get_transactions_throughput method/subscription in gRPC API #3426

Closed
2 tasks done
aoudiamoncef opened this issue Jan 16, 2023 · 0 comments · Fixed by #3683
Closed
2 tasks done

Implement get_transactions_throughput method/subscription in gRPC API #3426

aoudiamoncef opened this issue Jan 16, 2023 · 0 comments · Fixed by #3683
Assignees
@modship
Labels
api Issues related to the API enhancement New feature or request good first issue Good for newcomers

Comments

@aoudiamoncef
Copy link
Contributor

aoudiamoncef commented Jan 16, 2023 •
edited by modship
Loading

Actually(testnet18), transactions throughput is calculated in client side:
See https://github.com/massalabs/massa-explorer/blob/main/massa_demo_files/explorer.js#L717

We could implement this in backend side as JsonRPC method and a WebSocket:

  • get_transactions_throughput
  • subscribe_transactions_throughput/unsubscribe_transactions_throughput
@aoudiamoncef aoudiamoncef added enhancement New feature or request api Issues related to the API client good first issue Good for newcomers labels Jan 16, 2023
@aoudiamoncef aoudiamoncef mentioned this issue Jan 16, 2023
Closed
41 tasks
@aoudiamoncef aoudiamoncef changed the title Implement get_transactions_throughput method/subscription in JsonRPC API(V2) Implement get_transactions_throughput method/subscription in gRPC API Feb 21, 2023
@modship modship self-assigned this Mar 14, 2023
@modship modship linked a pull request Mar 14, 2023 that will close this issue
implement get_transactions_throughput #3683
Merged
7 tasks
@modship modship mentioned this issue Mar 14, 2023
Merged
23 tasks
aoudiamoncef added a commit that referenced this issue Apr 4, 2023
@aoudiamoncef
Support Protobuf and gRPC (#3443)
9a93440 
Co-authored-by: modship <[email protected]>

closes #3600 #3420 #3423 #3652 #3621 #3421 #3419 #3426 #3491 #3422 #3406 #3448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modship modship

Labels
api Issues related to the API enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement get_transactions_throughput massalabs/massa
2 participants
@modship @aoudiamoncef