Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Protobuf and gRPC #3443

Merged
merged 84 commits into from
Apr 4, 2023
Merged

Support Protobuf and gRPC #3443

merged 84 commits into from
Apr 4, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Jan 18, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Tasks:

List of included methods:

closes #3406 #3448

@aoudiamoncef aoudiamoncef force-pushed the feature/testnet-19-grpc branch from 5dc0d3d to 682093f Compare January 19, 2023 17:36
@aoudiamoncef aoudiamoncef force-pushed the feature/testnet-19-grpc branch 2 times, most recently from 4092cad to e9f99c6 Compare January 24, 2023 09:54
@aoudiamoncef aoudiamoncef added the blocked Issues that can't be done for now. label Jan 24, 2023
@AurelienFT AurelienFT changed the base branch from testnet_19 to testnet_20 February 1, 2023 15:03
@aoudiamoncef aoudiamoncef force-pushed the feature/testnet-19-grpc branch from e9f99c6 to fde8e47 Compare February 6, 2023 13:49
@aoudiamoncef aoudiamoncef force-pushed the feature/testnet-19-grpc branch from 5dc3acb to f938f5c Compare February 13, 2023 16:34
@aoudiamoncef aoudiamoncef force-pushed the feature/testnet-19-grpc branch from f938f5c to 6aaa1ab Compare February 21, 2023 19:01
@aoudiamoncef aoudiamoncef added wip and removed blocked Issues that can't be done for now. labels Feb 21, 2023
@aoudiamoncef aoudiamoncef force-pushed the feature/testnet-19-grpc branch 4 times, most recently from cd65740 to 59230f9 Compare February 28, 2023 23:54
@AurelienFT AurelienFT changed the base branch from testnet_20 to testnet_21 March 1, 2023 09:38
@aoudiamoncef aoudiamoncef force-pushed the feature/testnet-19-grpc branch 5 times, most recently from 2a100b3 to 64ca34a Compare March 2, 2023 20:45
@aoudiamoncef
Copy link
Contributor Author

Hi @AurelienFT,

IMHO, It's better to validated the build + send_blocks before continuing the work on other methods.

@aoudiamoncef aoudiamoncef force-pushed the feature/testnet-19-grpc branch from 1088c7b to 0c9f4cf Compare March 3, 2023 21:27
massa-grpc/src/api.rs Outdated Show resolved Hide resolved
massa-grpc/src/api.rs Outdated Show resolved Hide resolved
massa-grpc/src/api.rs Outdated Show resolved Hide resolved
massa-grpc/src/api.rs Outdated Show resolved Hide resolved
@aoudiamoncef
Copy link
Contributor Author

aoudiamoncef commented Mar 31, 2023

@AurelienFT we got this in the CI:

➜  massa git:(feature/testnet-19-grpc) ✗ cargo doc --no-deps --all-features --document-private-items
warning: /Users/aoudiamoncef/Workspace/massa/massa-node/Cargo.toml: unused manifest key: build
warning: external crate `criterion` unused in `massa_execution_worker`: remove the dependency or add `use criterion as _;`
  --> massa-execution-worker/src/lib.rs:3:1
   |
3  | //! # General description
   | ^
   |
note: the lint level is defined here
  --> massa-execution-worker/src/lib.rs:80:9
   |
80 | #![warn(unused_crate_dependencies)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^

solution:

#[cfg(any(feature = "benchmarking"))]
use criterion as _;

Could I add the compiler suggestion ?

Update: I did it and all is green

@aoudiamoncef
Copy link
Contributor Author

aoudiamoncef commented Mar 31, 2023

I did a complete fix for all lints detected by buf lint (locally)

In tesnet 22, we could add buf Github Action build to our CI to keep the doc sync ?

image

Doc preview: https://refined-github-html-preview.kidonng.workers.dev/massalabs/massa/raw/feature/testnet-19-grpc/massa-proto/doc/index.html

@AurelienFT
Copy link
Contributor

I think this is ready for merge @aoudiamoncef and @modship. Nice work ! 🎉

@aoudiamoncef
Copy link
Contributor Author

Hi 👋, I have to add some missing comments in the doc and we'll merge It

@aoudiamoncef
Copy link
Contributor Author

Finally, we are done with this huge PR a big up to @modship for your help 🥇

A big thank for @AurelienFT && @Leo-Besancon for your code reviews 👍🏻

Let's see the feedbacks in testnet 21 🚀

@AurelienFT
Copy link
Contributor

Nice work guys, this is a clean first version and a great startup point ! 🎉

@aoudiamoncef aoudiamoncef merged commit 9a93440 into testnet_21 Apr 4, 2023
@AurelienFT AurelienFT deleted the feature/testnet-19-grpc branch May 29, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants