-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Protobuf and gRPC #3443
Conversation
5dc0d3d
to
682093f
Compare
4092cad
to
e9f99c6
Compare
e9f99c6
to
fde8e47
Compare
5dc3acb
to
f938f5c
Compare
f938f5c
to
6aaa1ab
Compare
cd65740
to
59230f9
Compare
2a100b3
to
64ca34a
Compare
Hi @AurelienFT, IMHO, It's better to validated the build + send_blocks before continuing the work on other methods. |
1088c7b
to
0c9f4cf
Compare
@AurelienFT we got this in the CI:
solution: #[cfg(any(feature = "benchmarking"))]
use criterion as _; Could I add the compiler suggestion ? Update: I did it and all is green |
I did a complete fix for all lints detected by buf lint (locally) In tesnet 22, we could add buf Github Action build to our CI to keep the doc sync ? |
I think this is ready for merge @aoudiamoncef and @modship. Nice work ! 🎉 |
Hi 👋, I have to add some missing comments in the doc and we'll merge It |
Finally, we are done with this huge PR a big up to @modship for your help 🥇 A big thank for @AurelienFT && @Leo-Besancon for your code reviews 👍🏻 Let's see the feedbacks in testnet 21 🚀 |
Nice work guys, this is a clean first version and a great startup point ! 🎉 |
Tasks:
List of included methods:
send_blocks
method in gRPC API #3420send_endorsements
method in gRPC API #3423send_operations
method in gRPC API #3652get_datastore_entries
in gRPC API #3621get_selector_draws
method in gRPC API #3421get_next_block_best_parents
method in gRPC API #3419get_transactions_throughput
method/subscription in gRPC API #3426get_executed_operations
method #3422closes #3406 #3448