Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massa gRPC API V2 #3377

Closed
37 of 41 tasks
aoudiamoncef opened this issue Jan 5, 2023 · 3 comments
Closed
37 of 41 tasks

Massa gRPC API V2 #3377

aoudiamoncef opened this issue Jan 5, 2023 · 3 comments
Labels
api Issues related to the API enhancement New feature or request

Comments

@aoudiamoncef
Copy link
Contributor

aoudiamoncef commented Jan 5, 2023

This issue tracks the work in progress on the newer Massa JsonRPC API.

Refactor the API:

1 - Specify the business needs with Core, the Innovation team, direct users (eg. Dusa) and the community Builders. Try to split endpoints as much as possible. Use snake_case everywhere (#2823). Decide if we fuse the private/public APIs and allow finer access control through other means.

2 - Write a new API that uses https://github.com/hyperium/tonic crate and will support the following features:

3 - Let's also add the following endpoints:

4 - As well as streaming methods for:

Existing WebSockets should be migrated to equivalent gRPC streams.

There is a discussion about gRPC support.
This will pave the way towards #2903 in particular, and also help @BatiGencho with execution event streaming for web3.

previously #2799 #3076

@aoudiamoncef aoudiamoncef added enhancement New feature or request api Issues related to the API wip labels Jan 5, 2023
@aoudiamoncef
Copy link
Contributor Author

Hi @massalabs/core-team,

As we are going to accelerate the development of Massa API V2, we are gathering all enhancements proposals in this issue.

Based on clients feedbacks, I made the list of methods/subscriptions/features above, we should select, drop and prioritise what's really add a value to Massa.

I'm waiting for feedbacks, feel free to update and/or comment issue.

Thanks 👍🏻

@aoudiamoncef aoudiamoncef changed the title Massa JsonRPC API V2 Massa Json(g)RPC API V2 Jan 16, 2023
@aoudiamoncef aoudiamoncef changed the title Massa Json(g)RPC API V2 Massa gRPC API V2 Feb 21, 2023
@banool
Copy link

banool commented Apr 19, 2023

I see you have ticked off "Support gateway annotations", how are you planning to implement that given it isn't supported in the underlying libraries?

@aoudiamoncef
Copy link
Contributor Author

Hi @banool

We added gateway annotations in our gRPC service definition to be used by reverse proxies Eg Envoy and other languages E.g in go

In the future, if Prost/Tonic adds support for a Rust based gateway, we're already ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants