Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for success notification type #5710

Merged
merged 4 commits into from
Dec 23, 2020
Merged

Add support for success notification type #5710

merged 4 commits into from
Dec 23, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Dec 22, 2020 •
edited
Loading

Supersedes #5624

@fzaninotto fzaninotto changed the title Fix Notification component colors Add support for success notification type Dec 23, 2020
@fzaninotto fzaninotto merged commit df3892d into marmelab:next Dec 23, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.12 milestone Dec 23, 2020
@fzaninotto fzaninotto mentioned this pull request Dec 23, 2020
Closed
@WiXSL WiXSL deleted the fix-notification-colors branch December 23, 2020 12:41
@fzaninotto fzaninotto mentioned this pull request Jan 3, 2021
Merged
@fzaninotto
Copy link
Member

I realize this changes the color of all the default notifications in a way I really don't like. It feels like a regression to me.

I'll revert this PR (and #5724) so that we can rediscuss that without blocking 3.12, which is around the corner.

@fzaninotto fzaninotto mentioned this pull request Jan 28, 2021
Merged
@fzaninotto fzaninotto removed this from the 3.12 milestone Jan 28, 2021
@fzaninotto
Copy link
Member

In particular, the "Undo" is not visible

image

@WiXSL
Copy link
Contributor Author

WiXSL commented Jan 29, 2021

Ok.
I will love to have success, info, warning and error colors anyways in the future, since right now, notifications warning and error colors are both red and success and info are both black.
Let me now if aI can make a related PR.

@WiXSL WiXSL mentioned this pull request Feb 26, 2021
Merged
@fzaninotto fzaninotto mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WiXSL @fzaninotto