Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NotificationType type. #5624

Closed
wants to merge 1 commit into from
Closed

Update NotificationType type. #5624

wants to merge 1 commit into from

Conversation

hieusmiths
Copy link
Contributor

Addi success type

@hieusmiths
Copy link
Contributor Author

With Notification, i think we should support success type for sync with material or some thing operator between info and success

@djhi
Copy link
Collaborator

djhi commented Dec 4, 2020

If we want to support a success variant, this PR should also update the custom styles in the Notification component as we don't ues the Alert component from material-ui. I'm not sure we want this variant though. Ping @fzaninotto

@hieusmiths
Copy link
Contributor Author

If we want to support a success variant, this PR should also update the custom styles in the Notification component as we don't ues the Alert component from material-ui. I'm not sure we want this variant though. Ping @fzaninotto

Okay, I will update the custom style for Notification success type more.

@hieusmiths hieusmiths marked this pull request as draft December 4, 2020 10:19
@fzaninotto
Copy link
Member

I'm OK with adding this level

@fzaninotto
Copy link
Member

Any updates on this one?

@hieusmiths
Copy link
Contributor Author

Any updates on this one?

Now I don't have time for an update, maybe is future.

@fzaninotto fzaninotto mentioned this pull request Dec 18, 2020
Closed
This was referenced Dec 22, 2020
Closed
Merged
@fzaninotto
Copy link
Member

Superseded by #5710

@fzaninotto fzaninotto closed this Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hieusmiths @djhi @fzaninotto