Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Notification component colors definitions #6190

Closed
wants to merge 2 commits into from

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Apr 19, 2021

This change matches info, error and warning CSS rules with material-ui's for the Notification component.

notification-colors

@fzaninotto
Copy link
Member

You've already proposed a similar change in #5710, and I said then that we don't want it in core. Why should we merge it now?

Also, this can be achieved in userland through themes.

@WiXSL
Copy link
Contributor Author

WiXSL commented Apr 19, 2021

Ok.
This PR was after #6189 was merged but before you revert it, plus I thought the main problem of this type of change was the color of the undo button text which was fixed (before reverting) in #6189. So I move on with this proposal.
Now I understand.
Closing

@WiXSL WiXSL closed this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants