Render themes: line symbol

[andreynovikov]

https://github.com/mapsforge/vtm/blob/master/vtm/src/org/oscim/theme/XmlThemeBuilder.java#L258

Useful for aerialway icons.

[devemux86]

And oneways too!

lineSymbol is coming from Mapsforge and I'm not sure we need to have it as a new tag.
Line texture can suffice, provided that we enhance the stipple attributes with a repeat-gap.
Currently stipple attribute plays the role of both the texture length and the gap.

[andreynovikov]

Not really. Line texture is aligned (rotated) along line. Line symbol should remain vertical, like node symbol.

[devemux86]

Actually in Mapsforge we have an extra attribute rotate for that, with default behavior to be aligned with the line.

[andreynovikov]

Then ok, will wait for implementation.

[Klaus-Tockloth]

I use lineSymbol for cliffs and for one-way streets. It would be great if this feature could be implemented.

[devemux86]

Thanks to PR #388 by @Longri for Mapsforge theme compatibility, we have now an implementation of line symbols also in VTM themes.

[devemux86]

cc @Longri
Oneways don't render correctly, could need more work.

[devemux86]

I pushed the needed fixes for line symbols.

[devemux86]

Oneways with the lineSymbol rule:

[andreynovikov]

Have tried this new feature for cliffs and failed. Looks like repeat-gap with value less then 30 does not work. I've thought it's because of repeat-start, have set it to 0 but still get too large gaps between symbols.

[devemux86]

Isn't the natural=cliff rendering supposed to be with symbols having some distance among them?

Also it depends on symbols quality. If the symbols have much empty space around in their canvas, then they cannot be much close, even if put small repeat-gap.

[andreynovikov]

Yes. But the distance is too large. I use square icon with a tick: https://github.com/andreynovikov/maptrek/blob/master/app/src/main/assets/symbols/natural/cliff.svg There is no much space around. But the gap between symbols is about 1 centimeter on smartphone screen.

[devemux86]

Trying even with the oneway symbol which doesn't have empty canvas at its width and with repeat-gap="0" repeat-start="0", we cannot achieve continuous symbols rendering.

That seems related to the underlying stipples mechanism and not with line symbols (using it).
You can create a new issue to check it there.