Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapsforge themes compatibility #100

Closed
stleusc opened this issue Aug 1, 2016 · 12 comments
Closed

Mapsforge themes compatibility #100

stleusc opened this issue Aug 1, 2016 · 12 comments
Milestone

Comments

@stleusc
Copy link

stleusc commented Aug 1, 2016

are there plans to support mapsforge theme format?

@devemux86
Copy link
Collaborator

devemux86 commented Aug 1, 2016

It's not trivial task, as they're different rendering engines.
Nevertheless it's already in todo list for VTM.

@devemux86 devemux86 changed the title using mapsforge theme format Mapsforge themes compatibility Aug 16, 2016
@devemux86 devemux86 reopened this Aug 16, 2016
@devemux86
Copy link
Collaborator

devemux86 commented Aug 22, 2017

Mapsforge and VTM use different priority ordering.
In Mapsforge higher priorities are drawn first (priority 1 wins priority 0).
In VTM lower priorities are drawn first (priority 0 wins priority 1).

@Longri
Copy link

Longri commented Aug 22, 2017

Mapsforge and VTM use different zoom-levels.
VTM zoom 9 = Mapsforge zoom 10

@devemux86
Copy link
Collaborator

Mapsforge and VTM use different zoom-levels.

What do you mean?

If use same tile size (e.g. 512px) and exact same map position, we have the same map view.
i.e. in VTM use integer zoom, not double intermediate scales.

In #217 I explain in detail the zoom / scale in the two libs, specifically here.

Mapsforge
mapsforge

VTM
vtm

@Longri
Copy link

Longri commented Aug 22, 2017

Look into theme-comparator/src/org/oscim/theme_comparator/BothMapPositionHandler.java
Line 54
Only with different zoom we have the same representation. See on Mapscale!

@devemux86
Copy link
Collaborator

Have you set tile size 512px in Mapsforge (default 256px) like in VTM (default 512px) ?

@devemux86
Copy link
Collaborator

devemux86 commented Aug 22, 2017

I pushed the common tile size / zoom fix in b110314.

@devemux86 devemux86 added this to the 0.9.0 milestone Sep 3, 2017
@devemux86
Copy link
Collaborator

Thanks to PR #388 by @Longri we now have Mapsforge theme compatibility!

See VTM rendering OpenAndroMaps maps with Elevate theme:
opengl_openandromaps_elevate

@devemux86
Copy link
Collaborator

devemux86 commented Sep 3, 2017

Don't know if need to support the Mapsforge display directive, since VTM LabelLayer works already fine and differently than Mapsforge.

Also for any missing rules, would need first to implement them separately in VTM and then proceed with their Mapsforge support.

@devemux86
Copy link
Collaborator

After fixing #124, most needed functions are present and working.
So closing, any extra features can be checked in their own issues.

@devemux86
Copy link
Collaborator

OpenAndroMaps forum topic with feedback is here.

@devemux86
Copy link
Collaborator

I merged VTM + Mapsforge theme parsers for easier maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants