feat: fixed audit findings #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGcarv
added
Priority: Critical
Status: Ready for Review
Priority: High
and removed
Priority: Critical
labels
lucas-manuel
suggested changes
Nov 11, 2021
contracts/DebtLocker.sol
Outdated
| uint256 fundsCaptured = _fundsToCapture; | ||
|
|
||
| // Funds recovered from liquidation and any unclaimed previous payment amounts | ||
| uint256 recoveredFunds = IERC20Like(fundsAsset).balanceOf(address(this)) - fundsCaptured; |
contracts/DebtLocker.sol
Outdated
| @@ -209,19 +211,24 @@ contract DebtLocker is IDebtLocker, DebtLockerStorage, MapleProxied { | |||
| require(!_isLiquidationActive(), "DL:HCOR:LIQ_NOT_FINISHED"); | |||
|
|
|||
| address fundsAsset = IMapleLoanLike(_loan).fundsAsset(); | |||
| uint256 recoveredFunds = IERC20Like(fundsAsset).balanceOf(address(this)); // Funds recovered from liquidation and any unclaimed previous payment amounts | |||
| uint256 principalToCover = _principalRemainingAtLastClaim; // Principal remaining at time of liquidation | |||
| uint256 principalToCover = _principalRemainingAtLastClaim; // Principal remaining at time of liquidation | |||
There was a problem hiding this comment.
Needs another space before comment
contracts/test/DebtLocker.t.sol
Outdated
| assertEq(debtLocker.principalRemainingAtLastClaim(), loan.principalRequested()); | ||
| assertEq(debtLocker.fundsToCapture(), 0); | ||
|
|
||
| //trigger default |
lucas-manuel
pushed a commit
that referenced
this pull request
Nov 11, 2021
* chore: start cleaning up debt locker * feat: add README * feat: fixed audit findings (#23) * feat: fixed audit findings * fix: PR comments * formatting: update comments Co-authored-by: Lucas <[email protected]> Co-authored-by: Joao Gabriel Carvalho <[email protected]>
deluca-mike
added a commit
that referenced
this pull request
Dec 12, 2021
lucas-manuel
pushed a commit
that referenced
this pull request
Dec 12, 2021
lucas-manuel
pushed a commit
that referenced
this pull request
Dec 12, 2021
* chore: Remove TODO on pullFunds (c4 #10) * chore: strict 0.8.7 (c4 #23) * fix: Add named returns where missing (c4 #25) Co-authored-by: Lucas Manuel <[email protected]>
lucas-manuel
pushed a commit
that referenced
this pull request
Dec 12, 2021
* chore: Remove TODO on pullFunds (c4 #10) * chore: strict 0.8.7 (c4 #23) * fix: Add named returns where missing (c4 #25) * fix: `handleClaimOfRepossessed` gas optimization (c4 #66) Co-authored-by: Lucas Manuel <[email protected]>
lucas-manuel
pushed a commit
that referenced
this pull request
Dec 12, 2021
* chore: Remove TODO on pullFunds (c4 #10) * chore: strict 0.8.7 (c4 #23) * fix: Add named returns where missing (c4 #25) * fix: `handleClaimOfRepossessed` gas optimization (c4 #66) * fix: `getExpectedAmount` gas savings (c4 #62) * formatting: use loan instead of loanAddress Co-authored-by: Lucas Manuel <[email protected]>
lucas-manuel
pushed a commit
that referenced
this pull request
Dec 13, 2021
* chore: Remove TODO on pullFunds (c4 #10) * chore: strict 0.8.7 (c4 #23) * fix: Add named returns where missing (c4 #25) * fix: `handleClaimOfRepossessed` gas optimization (c4 #66) * fix: `getExpectedAmount` gas savings (c4 #62) * fix: Use `!= 0` instead of `> 0` (c4 #24) * fix: Input validation for `setAllowedSlippage` (c4 #45) * refactor: POst-C4 Audit Cleanup - natspec, spacing, and alignment - factory `mapleGlobals_` check now handled by mpf - `success_` -> `success` for non-param variable - reordered `DebtLockerStorage` - take latest dependencies - `acceptNewTerms` gas savings - `claim`, `_handleClaimOfRepossessed`, and `_handleClaim` gas savings - `_isLiquidationActive` gas savings - `triggerDefault` gas savings Co-authored-by: Joao Gabriel Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the 2 issues found during debt locker audit