fix: Add named returns where missing (C4 #25) (#43)

* chore: Remove TODO on pullFunds (c4 #10) * chore: strict 0.8.7 (c4 #23) * fix: Add named returns where missing (c4 #25) Co-authored-by: Lucas Manuel <[email protected]>
maple-labs · Dec 12, 2021 · 2ffdc24 · 2ffdc24
1 parent 0ab8614
commit 2ffdc24
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/contracts/DebtLocker.sol b/contracts/DebtLocker.sol
@@ -251,7 +251,7 @@ contract DebtLocker is IDebtLocker, DebtLockerStorage, MapleProxied {
         return oracleAmount > minRatioAmount ? oracleAmount : minRatioAmount;
     }
 
-    function implementation() external view override returns (address) {
+    function implementation() external view override returns (address implementation_) {
         return _implementation();
     }
 
@@ -279,7 +279,7 @@ contract DebtLocker is IDebtLocker, DebtLockerStorage, MapleProxied {
         return _pool;
     }
 
-    function poolDelegate() external override view returns(address) {
+    function poolDelegate() external override view returns (address poolDelegate_) {
         return _getPoolDelegate();
     }
 
@@ -299,15 +299,15 @@ contract DebtLocker is IDebtLocker, DebtLockerStorage, MapleProxied {
     /*** Internal View Functions ***/
     /*******************************/
 
-    function _getGlobals() internal view returns (address) {
+    function _getGlobals() internal view returns (address globals_) {
         return IPoolFactoryLike(IPoolLike(_pool).superFactory()).globals();
     }
 
-    function _getPoolDelegate() internal view returns(address) {
+    function _getPoolDelegate() internal view returns(address poolDelegate_) {
         return IPoolLike(_pool).poolDelegate();
     }
 
-    function _isLiquidationActive() internal view returns (bool) {
+    function _isLiquidationActive() internal view returns (bool isActive_) {
         return (_liquidator != address(0)) && (IERC20Like(IMapleLoanLike(_loan).collateralAsset()).balanceOf(_liquidator) > 0);
     }