refactor: Post-C4 Audit Cleanup #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- natspec, spacing, and alignment - factory `mapleGlobals_` check now handled by mpf - `success_` -> `success` for non-param variable - reordered `DebtLockerStorage` - take latest dependencies - `acceptNewTerms` gas savings - `claim`, `_handleClaimOfRepossessed`, and `_handleClaim` gas savings - `_isLiquidationActive` gas savings - `triggerDefault` gas savings
deluca-mike
assigned JGcarv, lucas-manuel and deluca-mike and unassigned JGcarv and lucas-manuel
deluca-mike
changed the title
lucas-manuel
force-pushed
the
sc-4298-c4-issue-45-input-validation-for-setallowedslippage
branch
from
19d33d5 to
3d62209
Compare
Base automatically changed from
sc-4298-c4-issue-45-input-validation-for-setallowedslippage
to
main
December 12, 2021 23:48
deluca-mike
force-pushed
the
refactor/cleanup-post-c4
branch
from
e1ecf42 to
7cbbaa3
Compare
deluca-mike
changed the title
lucas-manuel
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapleGlobals_check now handled by mpfsuccess_->successfor non-param variableDebtLockerStorageacceptNewTermsgas savingsclaim,_handleClaimOfRepossessed, and_handleClaimgas savings_isLiquidationActivegas savingstriggerDefaultgas savingsDescription
Integrations Checklist
Changelog
Function Signature Changes
Features
Events