Map + Location Animators #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
reviewed
Feb 19, 2018
| } | ||
| } | ||
|
|
||
| private static float normalizeBearing(float currentBearing, float targetBearing) { |
There was a problem hiding this comment.
We should just extract this method into the Utils class since I already use the same logic in LocationLayerPlugin
There was a problem hiding this comment.
@cammace Sure thing. Just porting this code from mapbox/mapbox-navigation-android#679 - will look to clean up and remove duplicate code as the PR progresses
* Add style / tracking modes for camera integration * Fix broken tests * API tweaks and example update
* Update with render / camera modes * Update camera with mode manager and cancel animation check * Update method compass name
* initial LocationLayerPlugin cleanup * added the animator class * animator implementation in the LocationLayer * reworked location layer camera * added Animator to LocationLayerPlugin * adjusted location activities * animator order fix * last values ordering fix * string fixes * Fix GPS layer * using previous animated value when starting a new one * small tweaks * setting accuracy ring only if using the right mode
2 tasks
* Clean up and javadoc * Updates per review
* [location-layer-plugin] - improve setting location engine * [location-layer-plugin] - attaching location engine listener when resetting the engine
* Clean up and javadoc * Add long click listener * Add max / min zoom and padding APIs * Fix javadoc * Add default values to options
LukasPaczos
added
the
location-layer-plugin
* [location-layer-plugin] - bumped maps SDK to 6.x * [location-layer-plugin] - style options initialization fixes * [location-layer-plugin] - added gestures handling implementation
* Add style / tracking modes for camera integration * Fix broken tests * API tweaks and example update
* Update with render / camera modes * Update camera with mode manager and cancel animation check * Update method compass name
* initial LocationLayerPlugin cleanup * added the animator class * animator implementation in the LocationLayer * reworked location layer camera * added Animator to LocationLayerPlugin * adjusted location activities * animator order fix * last values ordering fix * string fixes * Fix GPS layer * using previous animated value when starting a new one * small tweaks * setting accuracy ring only if using the right mode
* Clean up and javadoc * Updates per review
* [location-layer-plugin] - improve setting location engine * [location-layer-plugin] - attaching location engine listener when resetting the engine
* Clean up and javadoc * Add long click listener * Add max / min zoom and padding APIs * Fix javadoc * Add default values to options
* [location-layer-plugin] - bumped maps SDK to 6.x * [location-layer-plugin] - style options initialization fixes * [location-layer-plugin] - added gestures handling implementation
cammace
force-pushed
the
map-location-animators
branch
from
94520b5
to
bfe40e9
Compare
cammace
force-pushed
the
map-location-animators
branch
from
39f0812
to
1ccb76c
Compare
…gins-android into map-location-animators
* Add initial animators * Add Camera and Tracking Modes (#294) * Add style / tracking modes for camera integration * Fix broken tests * API tweaks and example update * Update with Render / Camera Modes (#297) * Update with render / camera modes * Update camera with mode manager and cancel animation check * Update method compass name * Add animator class (#302) * initial LocationLayerPlugin cleanup * added the animator class * animator implementation in the LocationLayer * reworked location layer camera * added Animator to LocationLayerPlugin * adjusted location activities * animator order fix * last values ordering fix * string fixes * Fix GPS layer * using previous animated value when starting a new one * small tweaks * setting accuracy ring only if using the right mode * Cleanup stale runnable (#304) * only update the location layer accuracy when not in RenderMode.GPS (#306) * Improve enabling/disabling location layer plugin (#308) * LocationLayerPlugin Javadoc (#309) * Clean up and javadoc * Updates per review * LocationEngine listening to updates after resetting (#307) * [location-layer-plugin] - improve setting location engine * [location-layer-plugin] - attaching location engine listener when resetting the engine * Add max / min zoom and padding APIs (#313) * Clean up and javadoc * Add long click listener * Add max / min zoom and padding APIs * Fix javadoc * Add default values to options * Gestures logic for camera tracking, new telemetry library (#327) * [location-layer-plugin] - bumped maps SDK to 6.x * [location-layer-plugin] - style options initialization fixes * [location-layer-plugin] - added gestures handling implementation * Update dependencies * Add missing long click listener * [location-layer] - fix crash on startup * Smooth bearing animation * Add separate camera animators * Fix camera transitions between animators * Add reset function for switching camera modes * Add gps north functionality to camera animator * Camera transition updates * [location-layer-plugin] - fixed camera tracking callbacks * [location-layer-plugin] - decreased default max zoom * [location-layer-plugin] - saving state in LocationLayerModesActivity * update maps sdk to latest beta (#384) * update maps sdk to latest beta * fixed checkstyle
* [location-layer-plugin] - fixed gestures threshold * [location-layer-plugin] - layer drawable updates adjustments
* [android] - fix order of interpolator * [location-layer-plugin] - fine tuned scale values
…gins-android into map-location-animators
cammace
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will aim to add new, more powerful APIs for animating the
MapboxMapcamera. This functionality will include the ability to account for padding, zoom, and tilt when animating towards a targetedLatLng. Can be integrated with theLocationLayerto add the same camera tracking functionality found in the currentlyMyLocationViewin the Maps SDK.cc @tobrun @LukasPaczos