Default Dynamic Camera for Navigation UI #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
changed the title
|
Upstream work needed to unlock this --> mapbox/mapbox-plugins-android#293 |
|
|
tobrun
approved these changes
Mar 1, 2018
2 tasks
This was referenced Mar 7, 2018
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #601 #678 #725
First pass will create a default
DynamicCamerathat usesMapboxMap#getCameraForLatLngBoundsto get a dynamic zoom based on our proximity to the upcoming maneuver. Will also add tilt based on the step distance remaining.DynamicCameracc @ericrwolfe