Add max / min zoom and padding APIs #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
the
location-layer-plugin
LukasPaczos
suggested changes
Feb 27, 2018
| @@ -450,6 +494,19 @@ private void disableLocationLayerPlugin() { | |||
| locationLayer.hide(); | |||
| } | |||
|
|
|||
| private void updateMapWithOptions(LocationLayerOptions options) { | |||
| int[] padding = options.padding(); | |||
| if (options.padding() != null && options.padding().length == 4) { | |||
There was a problem hiding this comment.
No need to access options object again. Shouldn't be an issue, but worth cleaning up.
| /** | ||
| * Sets the maximum zoom level the map can be displayed at. | ||
| * <p> | ||
| * The default maximum zoom level is 22. The upper bound for this value is 25.5. |
There was a problem hiding this comment.
Can we add a higher default min zoom level to prevent jiggling when zoomed in extremely close?
LukasPaczos
approved these changes
Feb 27, 2018
cammace
pushed a commit
that referenced
this pull request
Mar 12, 2018
* Clean up and javadoc * Add long click listener * Add max / min zoom and padding APIs * Fix javadoc * Add default values to options
danesfeder
added a commit
that referenced
this pull request
Mar 28, 2018
* Add initial animators * Add Camera and Tracking Modes (#294) * Add style / tracking modes for camera integration * Fix broken tests * API tweaks and example update * Update with Render / Camera Modes (#297) * Update with render / camera modes * Update camera with mode manager and cancel animation check * Update method compass name * Add animator class (#302) * initial LocationLayerPlugin cleanup * added the animator class * animator implementation in the LocationLayer * reworked location layer camera * added Animator to LocationLayerPlugin * adjusted location activities * animator order fix * last values ordering fix * string fixes * Fix GPS layer * using previous animated value when starting a new one * small tweaks * setting accuracy ring only if using the right mode * Cleanup stale runnable (#304) * only update the location layer accuracy when not in RenderMode.GPS (#306) * Improve enabling/disabling location layer plugin (#308) * LocationLayerPlugin Javadoc (#309) * Clean up and javadoc * Updates per review * LocationEngine listening to updates after resetting (#307) * [location-layer-plugin] - improve setting location engine * [location-layer-plugin] - attaching location engine listener when resetting the engine * Add max / min zoom and padding APIs (#313) * Clean up and javadoc * Add long click listener * Add max / min zoom and padding APIs * Fix javadoc * Add default values to options * Gestures logic for camera tracking, new telemetry library (#327) * [location-layer-plugin] - bumped maps SDK to 6.x * [location-layer-plugin] - style options initialization fixes * [location-layer-plugin] - added gestures handling implementation * Update dependencies * Add missing long click listener * [location-layer] - fix crash on startup * Smooth bearing animation * Add separate camera animators * Fix camera transitions between animators * Add reset function for switching camera modes * Add gps north functionality to camera animator * Camera transition updates * [location-layer-plugin] - fixed camera tracking callbacks * [location-layer-plugin] - decreased default max zoom * [location-layer-plugin] - saving state in LocationLayerModesActivity * update maps sdk to latest beta (#384) * update maps sdk to latest beta * fixed checkstyle
danesfeder
added a commit
that referenced
this pull request
Mar 28, 2018
* Add initial animators * Add Camera and Tracking Modes (#294) * Add style / tracking modes for camera integration * Fix broken tests * API tweaks and example update * Update with Render / Camera Modes (#297) * Update with render / camera modes * Update camera with mode manager and cancel animation check * Update method compass name * Add animator class (#302) * initial LocationLayerPlugin cleanup * added the animator class * animator implementation in the LocationLayer * reworked location layer camera * added Animator to LocationLayerPlugin * adjusted location activities * animator order fix * last values ordering fix * string fixes * Fix GPS layer * using previous animated value when starting a new one * small tweaks * setting accuracy ring only if using the right mode * Cleanup stale runnable (#304) * only update the location layer accuracy when not in RenderMode.GPS (#306) * Improve enabling/disabling location layer plugin (#308) * LocationLayerPlugin Javadoc (#309) * Clean up and javadoc * Updates per review * LocationEngine listening to updates after resetting (#307) * [location-layer-plugin] - improve setting location engine * [location-layer-plugin] - attaching location engine listener when resetting the engine * Add max / min zoom and padding APIs (#313) * Clean up and javadoc * Add long click listener * Add max / min zoom and padding APIs * Fix javadoc * Add default values to options * Gestures logic for camera tracking, new telemetry library (#327) * [location-layer-plugin] - bumped maps SDK to 6.x * [location-layer-plugin] - style options initialization fixes * [location-layer-plugin] - added gestures handling implementation * Update dependencies * Add missing long click listener * [location-layer] - fix crash on startup * Add initial animators * Add Camera and Tracking Modes (#294) * Add style / tracking modes for camera integration * Fix broken tests * API tweaks and example update * Update with Render / Camera Modes (#297) * Update with render / camera modes * Update camera with mode manager and cancel animation check * Update method compass name * Add animator class (#302) * initial LocationLayerPlugin cleanup * added the animator class * animator implementation in the LocationLayer * reworked location layer camera * added Animator to LocationLayerPlugin * adjusted location activities * animator order fix * last values ordering fix * string fixes * Fix GPS layer * using previous animated value when starting a new one * small tweaks * setting accuracy ring only if using the right mode * Cleanup stale runnable (#304) * only update the location layer accuracy when not in RenderMode.GPS (#306) * Improve enabling/disabling location layer plugin (#308) * LocationLayerPlugin Javadoc (#309) * Clean up and javadoc * Updates per review * LocationEngine listening to updates after resetting (#307) * [location-layer-plugin] - improve setting location engine * [location-layer-plugin] - attaching location engine listener when resetting the engine * Add max / min zoom and padding APIs (#313) * Clean up and javadoc * Add long click listener * Add max / min zoom and padding APIs * Fix javadoc * Add default values to options * Gestures logic for camera tracking, new telemetry library (#327) * [location-layer-plugin] - bumped maps SDK to 6.x * [location-layer-plugin] - style options initialization fixes * [location-layer-plugin] - added gestures handling implementation * Update dependencies * Add missing long click listener * [location-layer] - fix crash on startup * updated branch to latest on master * Fixed checkstyle error * fixed up ui test * use old mas lib for geojson plugin * Animator Updates (#349) * Add initial animators * Add Camera and Tracking Modes (#294) * Add style / tracking modes for camera integration * Fix broken tests * API tweaks and example update * Update with Render / Camera Modes (#297) * Update with render / camera modes * Update camera with mode manager and cancel animation check * Update method compass name * Add animator class (#302) * initial LocationLayerPlugin cleanup * added the animator class * animator implementation in the LocationLayer * reworked location layer camera * added Animator to LocationLayerPlugin * adjusted location activities * animator order fix * last values ordering fix * string fixes * Fix GPS layer * using previous animated value when starting a new one * small tweaks * setting accuracy ring only if using the right mode * Cleanup stale runnable (#304) * only update the location layer accuracy when not in RenderMode.GPS (#306) * Improve enabling/disabling location layer plugin (#308) * LocationLayerPlugin Javadoc (#309) * Clean up and javadoc * Updates per review * LocationEngine listening to updates after resetting (#307) * [location-layer-plugin] - improve setting location engine * [location-layer-plugin] - attaching location engine listener when resetting the engine * Add max / min zoom and padding APIs (#313) * Clean up and javadoc * Add long click listener * Add max / min zoom and padding APIs * Fix javadoc * Add default values to options * Gestures logic for camera tracking, new telemetry library (#327) * [location-layer-plugin] - bumped maps SDK to 6.x * [location-layer-plugin] - style options initialization fixes * [location-layer-plugin] - added gestures handling implementation * Update dependencies * Add missing long click listener * [location-layer] - fix crash on startup * Smooth bearing animation * Add separate camera animators * Fix camera transitions between animators * Add reset function for switching camera modes * Add gps north functionality to camera animator * Camera transition updates * [location-layer-plugin] - fixed camera tracking callbacks * [location-layer-plugin] - decreased default max zoom * [location-layer-plugin] - saving state in LocationLayerModesActivity * update maps sdk to latest beta (#384) * update maps sdk to latest beta * fixed checkstyle * Gestures thresholds adjustments (#386) * [location-layer-plugin] - fixed gestures threshold * [location-layer-plugin] - layer drawable updates adjustments * Fix order of interpolator expression (#388) * [android] - fix order of interpolator * [location-layer-plugin] - fine tuned scale values * Update feature import * fixup geojson * fixup checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add the improved
stops to the puck scalingAlso this is currently branched from
update-javadoc, so includes all the javadoc changes until they are merged. Still need to address @LukasPaczos comments in #309