Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Integrate MapboxDirections/RouteOptions refactor" #4651

Closed
wants to merge 1 commit into from

Conversation

kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Jul 21, 2021

Reverts #4526

Resolves #4650

The issue was caused by the 6.0.0-alpha.1 upgrade in mapbox-java mapbox/mapbox-java#1273

This means the fix will require a new release of mapbox-java. mapbox/mapbox-java#1274

Reverting the integration to unblock #4601 I did find a work around to unblock the replay use case #4650 (comment). Although that fix, has its own trade-offs.

Changelog

<changelog>Reverts :warning: Upgraded `mapbox-java` to `v6.0.0-alpha.1` which brings new features but also some breaking changes to `DirectionsRoute` and `MapboxDirections` objects. Read more about the changes in the [release notes](https://github.com/mapbox/mapbox-java/releases/tag/v6.0.0-alpha.1).</changelog>

@kmadsen kmadsen requested a review from a team as a code owner July 21, 2021 18:03
@kmadsen
Copy link
Contributor Author

kmadsen commented Jul 21, 2021

Closing in favor of #4652 and #4601

@kmadsen kmadsen closed this Jul 21, 2021
@kmadsen kmadsen deleted the revert-4526-lp-mapbox-java-refactored branch July 21, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay set route isn't working
1 participant