Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.0-alpha.1 changelog #1273

Merged
merged 1 commit into from
Jul 20, 2021
Merged

6.0.0-alpha.1 changelog #1273

merged 1 commit into from
Jul 20, 2021

Conversation

korshaknn
Copy link
Contributor

not sure if we should mention both

  • Stopped serializing access tokens #1267
  • Made the access token non-nullable in RouteOptions #1270

maybe a single [#1267] is enough.

@korshaknn korshaknn requested review from LukasPaczos and a team July 20, 2021 10:56
@LukasPaczos
Copy link
Contributor

Could you mention all of the listed changes from #1265 (comment) as separate lines?

@LukasPaczos
Copy link
Contributor

Made the access token non-nullable

This isn't needed 👍

@LukasPaczos
Copy link
Contributor

Also these should be listed #1265 (comment).

@korshaknn korshaknn force-pushed the knn-6.0.0-alpha.1-changelog branch from 501938a to 7e892ce Compare July 20, 2021 13:24
@korshaknn
Copy link
Contributor Author

@LukasPaczos ready to another round

Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise, lgtm. Could you also update the snapshot version to 6.0.0-SNAPSHOT?

@korshaknn korshaknn force-pushed the knn-6.0.0-alpha.1-changelog branch from 7e892ce to 20feba6 Compare July 20, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants