-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HistoryReader for navigation replay #4601
Conversation
e61e9d7
to
c7cdbb4
Compare
Robo tests seem to be failing because of this https://github.com/mapbox/mapbox-navigation-native/issues/3583 |
30fb7da
to
53aec7b
Compare
examples/src/main/java/com/mapbox/navigation/examples/core/replay/HistoryFilesDirectory.kt
Outdated
Show resolved
Hide resolved
examples/src/main/java/com/mapbox/navigation/examples/core/replay/HistoryFilesDirectory.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/history/model/HistoryEventMapper.kt
Outdated
Show resolved
Hide resolved
1bcc677
to
760d40e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments @kmadsen
...vigation-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayHistoryMapper.kt
Outdated
Show resolved
Hide resolved
...vigation-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayHistoryMapper.kt
Outdated
Show resolved
Hide resolved
...vigation-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayHistoryMapper.kt
Outdated
Show resolved
Hide resolved
760d40e
to
9402a12
Compare
5fb2396
to
8074a83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the feedback 🚀
8074a83
to
ffa1e66
Compare
ffa1e66
to
51b803a
Compare
Description
Resolves #4485
Adding the ability to replay pbf.gz files. Deleting the old path to replay only json files. This will continue to support the old json format, but you have to pass the file path to the
MapboxHistoryReader
.I have not found a way to read the
*.pbf.gz
formatted files in the assets or raw resource directories. I've had to copy the files into my device storage, and then read the file directly from there.Changelog
Screenshots or Gifs
replay-test.mp4