MAS 3.0 #373
Merged
MAS 3.0 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 14, 2017 18:24
cammace
added
✓ ready for review
and removed
⚠️ DO NOT MERGE
danesfeder
suggested changes
Oct 17, 2017
| String url = navigationRoute.getDirectionsRequest().cloneCall().request().url().toString(); | ||
| assertFalse(url.contains("radiuses=")); | ||
| } | ||
| //// @Test |
There was a problem hiding this comment.
Can we use @Ignore for this rather than commenting them out?
danesfeder
approved these changes
Oct 17, 2017
…roid into cam-mas-3.0
| @@ -42,8 +42,17 @@ android { | |||
|
|
|||
| dependencies { | |||
| // Mapbox Android Services | |||
| compile dependenciesList.mapboxServices | |||
| compile 'com.mapbox.mapboxsdk:mapbox-android-telemetry:2.2.6' | |||
There was a problem hiding this comment.
@cammace why hardcoding the dependencies? Right now, this wouldn't be necessary because 'com.mapbox.mapboxsdk:mapbox-android-services:2.2.6@aar' is including mapbox-android-telemetry.
I imagine this is in preparation for the upcoming version of MAS, right? BTW, we should keep including the definitions of the dependencies in dependenciesList.
Grsmto
pushed a commit
to Grsmto/mapbox-navigation-android
that referenced
this pull request
Oct 23, 2017
* master: (36 commits) Add bearing for each waypoint (mapbox#408) Adjust (port / land) Top Banners and add secondary text view (mapbox#404) Release 0.6.3 (mapbox#386) Add feedback method (mapbox#392) Project clean up (mapbox#397) limit routeline GeoJSON to maxzoom 16 to avoid creating more clipping mask for high zoom levels (mapbox#391) API Voice instructions (mapbox#394) MAS 3.0 (mapbox#373) Convert NavigationView to View (mapbox#346) only raw location in metrics (mapbox#349) only reroute once users traveled past 50 meters (mapbox#347) Account for different landscape view when adjusting drawable colors API 19 and below (mapbox#343) Send empty arrays properly (mapbox#354) send feedback identifier when the event happens (mapbox#359) Add Null check on the notification manager (mapbox#332) fix hardcoded feedback id generating a new one on each navigation session (mapbox#352) fixed broken link to test app in documentation (mapbox#357) adjusted readme to 0.6.2 (mapbox#333) Release v0.6.2 (mapbox#324) reroute metric (mapbox#296) ... # Conflicts: # app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/MockNavigationActivity.java # navigation/libandroid-navigation/build.gradle # navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/DefaultMilestones.java # navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/offroute/OffRouteDetector.java # scripts/release.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will unblock:
Voice instructions
Direction Profile in metrics
Reroute when a faster route becomes available
direction classes
Ability to parcel some objects (easier now)
Probably more... :)