only raw location in metrics #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericrwolfe
approved these changes
Oct 11, 2017
ericrwolfe
reviewed
Oct 11, 2017
| @@ -215,10 +217,10 @@ private boolean validLocationUpdate(Location location) { | |||
| @Override | |||
| public void onNewRouteProgress(Location location, RouteProgress routeProgress) { | |||
| this.routeProgress = routeProgress; | |||
| this.location = location; | |||
There was a problem hiding this comment.
Is there a reason to remove this given that we're using rawLocation below?
There was a problem hiding this comment.
the location given from the onNewRouteProgress is the snapped one that was causing issues. We now directly capture the users location right when the update occurs and before we perform any actions on it.
added 7 commits
October 11, 2017 10:21
Grsmto
pushed a commit
to Grsmto/mapbox-navigation-android
that referenced
this pull request
Oct 23, 2017
* master: (36 commits) Add bearing for each waypoint (mapbox#408) Adjust (port / land) Top Banners and add secondary text view (mapbox#404) Release 0.6.3 (mapbox#386) Add feedback method (mapbox#392) Project clean up (mapbox#397) limit routeline GeoJSON to maxzoom 16 to avoid creating more clipping mask for high zoom levels (mapbox#391) API Voice instructions (mapbox#394) MAS 3.0 (mapbox#373) Convert NavigationView to View (mapbox#346) only raw location in metrics (mapbox#349) only reroute once users traveled past 50 meters (mapbox#347) Account for different landscape view when adjusting drawable colors API 19 and below (mapbox#343) Send empty arrays properly (mapbox#354) send feedback identifier when the event happens (mapbox#359) Add Null check on the notification manager (mapbox#332) fix hardcoded feedback id generating a new one on each navigation session (mapbox#352) fixed broken link to test app in documentation (mapbox#357) adjusted readme to 0.6.2 (mapbox#333) Release v0.6.2 (mapbox#324) reroute metric (mapbox#296) ... # Conflicts: # app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/MockNavigationActivity.java # navigation/libandroid-navigation/build.gradle # navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/DefaultMilestones.java # navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/offroute/OffRouteDetector.java # scripts/release.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #340
Should never be using snapped location inside metrics now.