Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send empty arrays properly #354

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Send empty arrays properly #354

merged 2 commits into from
Oct 11, 2017

Conversation

Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 added bug Defect to be fixed. topic: telemetry labels Oct 11, 2017
@Guardiola31337 Guardiola31337 added this to the v0.6.3 milestone Oct 11, 2017
@Guardiola31337 Guardiola31337 self-assigned this Oct 11, 2017
@Guardiola31337
Copy link
Contributor Author

Addressed in #354 👇
Assuming:

  • beforeLocations or afterLocations
    • If null 👉 null
    • If empty 👉 []
    • If not empty 👉 [{}]

Is that correct ☝️ @ericrwolfe? If not, let me know. Should be easy to tweak.

cc @cammace

@ericrwolfe
Copy link
Contributor

  • beforeLocations or afterLocations
    • If null 👉 null
    • If empty 👉 []
    • If not empty 👉 [{}]

@Guardiola31337 Only change needed here would be:

  • If null 👉 []

@Guardiola31337
Copy link
Contributor Author

bdc0851 addressed your comment @ericrwolfe
Ready for a second round of 👀

@cammace cammace merged commit 6aeab1e into master Oct 11, 2017
@cammace cammace deleted the pg-337-locations-null branch October 11, 2017 21:56
danesfeder pushed a commit that referenced this pull request Oct 12, 2017
@Guardiola31337 @danesfeder
Send empty arrays properly (#354)
5e9a293 
* send an empty array when either locations before or after are empty arrays

* send empty array even when locations before and after are null
danesfeder added a commit that referenced this pull request Oct 12, 2017
@danesfeder
Convert NavigationView to View (#346)
d8615f7 
* Convert NavigationView to a plain view rather than Activity

* Add listener for notifying when navigation has ended

* Add leg steps if current step count is 0.  This will always be the case after rerouting

* Fix shadow hide / show throwing off bottomsheet peek height

* Use target distance for initial zoom

* Add map padding to prevent bottomsheet from covering puck

* Add Null check on the notification manager (#332)

* send feedback identifier when the event happens (#359)

* Send empty arrays properly (#354)

* send an empty array when either locations before or after are empty arrays

* send empty array even when locations before and after are null

* Account for different landscape view when adjusting drawable colors API 19 and below (#343)

* Set target distance based on view percentage of screen

* Throw class cast exceptions when NavigationView is inflated with invalid context

* Launch coordinates with navigation activity
Grsmto pushed a commit to Grsmto/mapbox-navigation-android that referenced this pull request Oct 23, 2017
Merge branch 'master' into fix-build
c6ce2db 
* master: (36 commits)
  Add bearing for each waypoint (mapbox#408)
  Adjust (port / land) Top Banners and add secondary text view (mapbox#404)
  Release 0.6.3 (mapbox#386)
  Add feedback method (mapbox#392)
  Project clean up (mapbox#397)
  limit routeline GeoJSON to maxzoom 16 to avoid creating more clipping mask for high zoom levels (mapbox#391)
  API Voice instructions (mapbox#394)
  MAS 3.0 (mapbox#373)
  Convert NavigationView to View  (mapbox#346)
  only raw location in metrics (mapbox#349)
  only reroute once users traveled past 50 meters (mapbox#347)
  Account for different landscape view when adjusting drawable colors API 19 and below (mapbox#343)
  Send empty arrays properly (mapbox#354)
  send feedback identifier when the event happens (mapbox#359)
  Add Null check on the notification manager (mapbox#332)
  fix hardcoded feedback id generating a new one on each navigation session (mapbox#352)
  fixed broken link to test app in documentation (mapbox#357)
  adjusted readme to 0.6.2 (mapbox#333)
  Release v0.6.2 (mapbox#324)
  reroute metric (mapbox#296)
  ...

# Conflicts:
#	app/src/main/java/com/mapbox/services/android/navigation/testapp/activity/MockNavigationActivity.java
#	navigation/libandroid-navigation/build.gradle
#	navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/DefaultMilestones.java
#	navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/offroute/OffRouteDetector.java
#	scripts/release.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericrwolfe ericrwolfe ericrwolfe approved these changes

@cammace cammace Awaiting requested review from cammace

Assignees

@Guardiola31337 Guardiola31337

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
v0.6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Guardiola31337 @ericrwolfe @cammace