fix raster-masking vertex indexing #5380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the raster clipping masks with the order of the mask vertices causing rendering artifacts with overlapping triangles which were only noticeable on zooming with translucent raster tiles.
This PR changes to use a
SegmentVector
with an explicitIndexArray
which solves the overlapping triangles when I manually tested the debug page, but I'm not sure the best way to write a unit/rendering test for this.Launch Checklist