Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix raster-masking vertex indexing #5380

Merged
merged 2 commits into from
Oct 2, 2017
Merged

fix raster-masking vertex indexing #5380

merged 2 commits into from
Oct 2, 2017

Conversation

mollymerp
Copy link
Contributor

There was a bug in the raster clipping masks with the order of the mask vertices causing rendering artifacts with overlapping triangles which were only noticeable on zooming with translucent raster tiles.

This PR changes to use a SegmentVector with an explicit IndexArray which solves the overlapping triangles when I manually tested the debug page, but I'm not sure the best way to write a unit/rendering test for this.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@mollymerp mollymerp requested a review from ansis September 28, 2017 23:57
@mollymerp
Copy link
Contributor Author

this very closely matches the native implementation

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps let's add a render test for that too?

@mollymerp
Copy link
Contributor Author

added a render test – here's the corresponding test on master with the artifacts
actual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants