Eliminate fill-extrude- props in favor of fill-extrusion type #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbud
added
the
breaking change ⚠️
jfirebaugh
approved these changes
Oct 28, 2016
lbud
force-pushed
the
fill-extrusion-type
branch
2 times, most recently
from
d74144d to
39886b6
Compare
added 5 commits
November 1, 2016 17:10
* Resolve Z units to meters (and move z scaling to transform for use in future other 3D types) Fixes #3385.
Turns out this was sitting on the very shaky house of cards that is relying on a different render call (when the gl.enable(gl.DEPTH_TEST) was removed from draw_symbol, this broke depth testing in extrusions 🙊)
lbud
force-pushed
the
fill-extrusion-type
branch
from
6e244be to
59cf630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs mapbox/mapbox-gl-style-spec#554 (companion PRs enumerated there).
No render diffs, no new functionality, no changes to APIs — this is 100% spec changes.
Fixes #3386