Get rid of user-specified refs #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 so psyched to see this happening, thx for working on it @jfirebaugh! |
|
This is great! I love how simple |
|
Rebased after #3487 and this is now passing. |
mourner
reviewed
Nov 3, 2016
There was a problem hiding this comment.
This looks fantastic! Remaining items:
- post benchmark scores
- merge Add deref mapbox-gl-style-spec#553
- rebase again to resolve package.json conflict
- update to a new style-spec sha
| this.buffers.destroy(); | ||
| this.buffers = null; | ||
| } | ||
| }} |
jfirebaugh
force-pushed
the
deref
branch
2 times, most recently
from
f6f4ef4 to
3d1ff7f
Compare
|
mourner
approved these changes
Nov 3, 2016
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #1393. Depends on mapbox/mapbox-gl-style-spec#553. Further development work waiting on mapbox/mapbox-gl-style-spec#554.