Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extrusion examples to use separate fill-extrusion type #3488

Merged
merged 2 commits into from
Nov 2, 2016

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Oct 28, 2016

Update extrusion-based examples (once #3487 is merged). Refs mapbox/mapbox-gl-style-spec#554.

@jfirebaugh
Copy link
Contributor

Can you retarget this at master, so that it goes live simultaneously with 0.27.0 being released?

@lbud
Copy link
Contributor Author

lbud commented Oct 28, 2016

@jfirebaugh I'm not sure how the relationship between master and mb-pages works — I targeted here based on release documentation I was going through the other day. Should I still retarget at master?

@jfirebaugh
Copy link
Contributor

There's more explanation here -- this case is admittedly borderline, since we're making a breaking change to an existing property. But I think it's better overall if we don't have a period of time where the published example won't work with the current released version, which would happen if we pushed to mb-pages before releasing 0.27.0.

@lbud
Copy link
Contributor Author

lbud commented Oct 28, 2016

@jfirebaugh makes sense, thanks 🙏

@lbud lbud closed this Oct 28, 2016
@lbud lbud changed the base branch from mb-pages to master October 28, 2016 23:35
@lbud lbud reopened this Oct 28, 2016
Copy link
Contributor

@lucaswoj lucaswoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge alongside #3487. It might even make sense to combine the two branches before merging into master.

@lbud lbud merged commit 33e2646 into master Nov 2, 2016
@lbud lbud deleted the fill-extrusion-examples-update branch November 2, 2016 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants