-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--bundle and --consolify don't play well with subfolders #140
Comments
Fixes mantoni#140 Add Test Coverage for --bundle and --consolify args * Fail with a useful error if the user tries to use --bundle wihout --consolify * Add test-coverage to check that both the consolify'd HTML and extracted bundle are written to disk
As mentioned in #141, I was unable to solve this in mochify.js directly as consolify is responsible for writing the bundle (and therefore requires the absolute path for its output). I can think of a couple of ways to solve this, but both will require a change to consolify's API and mochfy.js's invocation of it.
Welcome to any other suggestions you have @mantoni? |
@jonnyreeves I think it makes sense to add a |
What is the status here? What is left to do in mochify.js? |
The HTML runner generated using the
--consolify
flag does not resolve the relative path to the bundle generated by the--bundle
flag; instead the absolute value is used.Steps to repro:
Run
mochify
over a test suite specifying both a--bundle
and--consolify
flag whose value points to a subfolder (eg:tmp
).Expected
<script src="./tests.js">
)Actual
--bundle
flag (ie:<script src="tmp/tests.js>
)The text was updated successfully, but these errors were encountered: