Add Test Coverage for --bundle and --consolify args

[jonnyreeves]

• Fail with a useful error if the user tries to use --bundle wihout --consolify
• Add test-coverage to check that both the consolify'd HTML and extracted bundle are written to disk

[mantoni]

Hey, thanks! One thing: The bundle option is, well, optional :) If it's not provided, the bundle is inlined into the html file. Can I ask you to ensure this continues to work?

[jonnyreeves]

Ah sorry, I forgot to test that flow! Let me patch that up.

On Thu, 14 Jul 2016, 21:52 Maximilian Antoni, [email protected]
wrote:

Hey, thanks! One thing: The bundle option is, well, optional :) If it's
not provided, the bundle is inlined into the html file. Can I ask you to
ensure this continues to work?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#141 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAMN-Qe3Vv__ISyBQiDW_qRuYppt2aiFks5qVqGCgaJpZM4JM1D4
.

[jonnyreeves]

Hey @mantoni; so in adding test coverage I realised that this was the wrong place to make this fix - I'll raise a PR against consolify to ensure the bundle is still written to the correct location, just the script src value is changed to be relative.

Cheers

[jonnyreeves]

I could change this so it only affects tests if you would prefer?

[mantoni]

Awesome! Thanks a lot 👍