Add --outfile arg #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a destination path to be supplied; the standalone HTML file will be written here as well as being passed through to browserify.
All tests that write to the file system are now sandboxed so the files generated during the testcase are automatically removed at the end of the run without requiring manual cleanup
| if (done) { | ||
| done(); | ||
| out.on('end', done); |
There was a problem hiding this comment.
We need to wait for the async chain of fs.writeFile calls to compete
|
Awesome work! Thanks for the contribution. As an alternative to the custom |
|
@mantoni would you like me to remove the series util and replace it with a |
|
Sorry. This is good to land as is. Easy enough to change to listen.js later. Thanks again. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mantoni/mochify.js#140 for justification.
--outfilearg: writes the html file to a given path as well as passing it through to browserify.