-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds manylinux-based docker image for maliput wheel creation #315
Merged
francocipollone
merged 6 commits into
main
from
francocipollone/provide_wheel_generation_image
Oct 24, 2023
Merged
Adds manylinux-based docker image for maliput wheel creation #315
francocipollone
merged 6 commits into
main
from
francocipollone/provide_wheel_generation_image
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
francocipollone
added
do-manylinux-image-build
and removed
do-manylinux-image-build
labels
Oct 16, 2023
Signed-off-by: Franco Cipollone <[email protected]>
francocipollone
added
do-manylinux-image-build
and removed
do-manylinux-image-build
labels
Oct 16, 2023
6 tasks
Signed-off-by: Franco Cipollone <[email protected]>
francocipollone
added
do-manylinux-image-build
and removed
do-manylinux-image-build
labels
Oct 18, 2023
6 tasks
francocipollone
commented
Oct 19, 2023
Signed-off-by: Franco Cipollone <[email protected]>
francocipollone
added
do-manylinux-image-build
and removed
do-manylinux-image-build
labels
Oct 23, 2023
agalbachicar
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,23 @@ | |||
## Wheel generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For another PR, I think this should be in our public documentation (longer and more detailed documentation).
francocipollone
deleted the
francocipollone/provide_wheel_generation_image
branch
October 24, 2023 18:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π New feature
Related to #313
Summary
β Do not Merge yet! WIP
Checklist