Adds workflow for manylinux wheel creation. #248
Conversation
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
| @@ -19,7 +19,6 @@ include(GNUInstallDirs) | |||
| message(STATUS "\n\n====== Finding 3rd Party Packages ======\n") | |||
|
|
|||
| find_package(ament_cmake REQUIRED) | |||
| find_package(gflags REQUIRED) | |||
There was a problem hiding this comment.
This needs to be moved to src/applications/CMakelists.txt
CMakeLists.txt
Outdated
| include(python-wheel) | ||
| set(WHEEL_DEPLOY_DIRECTORY "${CMAKE_BINARY_DIR}/wheel") | ||
|
|
||
| set(DEPLOY_FILES "${PROJECT_SOURCE_DIR}/maliput_malidrive/__init__.py") |
There was a problem hiding this comment.
Don't we deploy the sample maps?
There was a problem hiding this comment.
DEPLOY_FILES accepts a list of files, I can't add a folder (in this case resources).
https://github.com/maliput/python-cmake-wheel/blob/main/python-wheel.cmake#L124-L131
I could use resources/* and that will copy all the files directly which will be a mess because they will be thrown in the wheel.
We could also extend that feature in order to accept folders. However probably it makes sense to leave it as an enhancement issue on top of this PR.
I am also thinking that probably, once that is done, we could add a method in the init file for getting a resource so it is easier to deal with.
There was a problem hiding this comment.
I think the tooling is lacking the ability to add data-files. Perhaps we can add it in the future. I agree with deferring that to a follow up PR.
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
francocipollone
force-pushed
the
francocipollone/manylinux_wheel
branch
from
aa925df to
251d271
Compare
Signed-off-by: Franco Cipollone <[email protected]>
francocipollone
force-pushed
the
francocipollone/manylinux_wheel
branch
from
251d271 to
149f942
Compare
|
CI is passing. PR ready to review @agalbachicar |
🎉 New feature
Pairs with maliput/maliput_infrastructure#315
❗ Do not Merge yet! WIP
Summary
manylinux2014-compatible wheel creation ofmaliput_malidriveChecklist