Fix CI #1216
Closed
Fix CI #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
force-pushed
the
fix-ci
branch
2 times, most recently
from
6ed4f9c to
5ef0454
Compare
bertdeblock
commented
Mar 7, 2024
| @@ -89,5 +90,9 @@ | |||
| "versionCompatibility": { | |||
| "ember": "3.8 || 3.12 || 3.16 || 3.20 || >=3.24" | |||
| } | |||
| }, | |||
| "volta": { | |||
There was a problem hiding this comment.
Might be useful for future Volta users, though I understand if you'd want this removed.
bertdeblock
commented
Mar 7, 2024
| @@ -1,8 +1,9 @@ | |||
| lockfileVersion: 5.4 | |||
| lockfileVersion: 5.3 | |||
There was a problem hiding this comment.
I've used pnpm v6.35.1 to install @ember/string, which is the same version used in CI. This means that this lock file was generated using a newer version, so pnpm downgrades it.
bertdeblock
commented
Mar 7, 2024
| const isProduction = process.env.EMBER_ENV === 'production'; | ||
|
|
||
| if (isCI || isProduction) { | ||
| browsers.push('ie 11'); |
There was a problem hiding this comment.
Removing ie 11 resolves (0 , _emberBabel.regeneratorRuntime) is not a function. If ie 11 is still needed, I can look for a different more correct solution.
bertdeblock
commented
Mar 7, 2024
| @@ -32,6 +32,7 @@ | |||
| "devDependencies": { | |||
| "@babel/core": "7.21.3", | |||
| "@ember/optional-features": "2.0.0", | |||
| "@ember/string": "3.1.1", | |||
There was a problem hiding this comment.
Resolves the @ember/string related deprecations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should unblock the new release.