Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ember-cli-babel v8 #1211

Closed
bertdeblock opened this issue Aug 19, 2023 · 2 comments · Fixed by #1213
Closed

Support ember-cli-babel v8 #1211

bertdeblock opened this issue Aug 19, 2023 · 2 comments · Fixed by #1213

Comments

@bertdeblock
Copy link
Contributor

bertdeblock commented Aug 19, 2023 •
edited
Loading

Seeing this warning at the moment:

WARNING: ember-test-selectors: You are using an unsupported ember-cli-babel version. data-test properties are not automatically stripped from your JS code.

Though, it seems stripping data-test selectors does still work.

EDIT: We don't use data-test selectors in JS land, so that's why the results I'm seeing are still the same.
@bertdeblock bertdeblock mentioned this issue Aug 21, 2023
Merged
@bwbuchanan
Copy link

Could we get a release cut with this change please?

@bertdeblock
Copy link
Contributor Author

Made #1216 to get the ball rolling on a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for ember-cli-babel v8 bertdeblock/ember-test-selectors
2 participants
@bwbuchanan @bertdeblock