Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ember-cli-babel v8 #1213

Merged

Conversation

bertdeblock
Copy link
Contributor

Builds on #1212.

Closes #1211.

@bertdeblock bertdeblock changed the title Add support for ember cli babel v8 Add support for ember-cli-babel v8 Sep 27, 2023
@jrjohnson
Copy link
Contributor

@marcoow or @Turbo87 (the last two non renovate commiters here). Can someone take a look at this? With ember-cli-babel v8 in the default blueprint this change is very much needed.

@marcoow
Copy link
Member

marcoow commented Sep 29, 2023

@bertdeblock can you rebase on #1212?

@bertdeblock bertdeblock force-pushed the add-support-for-ember-cli-babel-v8 branch from ab36f23 to cf1ce42 Compare October 31, 2023 09:03
@bertdeblock
Copy link
Contributor Author

@marcoow Rebased.

@marcoow
Copy link
Member

marcoow commented Oct 31, 2023

@bertdeblock tests fail with latest Ember versions…

@bertdeblock
Copy link
Contributor Author

That's already the case on master, so unrelated to this PR AFAICT.
Seems like the dummy app needs a bit of maintenance.

@marcoow
Copy link
Member

marcoow commented Oct 31, 2023

ah I see

@marcoow marcoow merged commit 70cdb83 into mainmatter:master Oct 31, 2023
16 of 19 checks passed
@Windvis
Copy link

Windvis commented Feb 2, 2024

@marcoow Is there any chance we can get a new release that includes this change? 🙏

@bertdeblock
Copy link
Contributor Author

#1216 fixes CI, can someone cut a release?

@gorner
Copy link

gorner commented Jul 3, 2024

@bertdeblock @marcoow any updates on a new release? I see #1216 was closed without merging but I'm not sure why.

@bertdeblock
Copy link
Contributor Author

Nope, I don't maintain this library. I closed that PR because I didn't want to wait anymore, and I don't use this library anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ember-cli-babel v8
6 participants