-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue #22736 - Cursor position not in right side of search keyword in mobile #22795
fixed issue #22736 - Cursor position not in right side of search keyword in mobile #22795
Conversation
…ch keyword in mobile
Hi @sanjaychouhan-webkul. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sanjaychouhan-webkul, this can get even simpler: this.element.focus().val(this.element.val())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sanjaychouhan-webkul, this can get even simpler: this.element.focus().val(this.element.val())
@VladimirZaets this does not work. also getting js error because we are triggering focus() event inside onFocus event handler. |
@VladimirZaets also |
Hi @VladimirZaets, thank you for the review. |
@@ -133,6 +133,9 @@ define([ | |||
|
|||
if (this.isExpandable) { | |||
this.element.attr('aria-expanded', isActive); | |||
let searchValue = this.element.val(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sanjaychouhan-webkul.
Currently, we support only ES5 syntax, so can you please change let
to var
and according to our technical guidelines variables declaration should be on the top of the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VladimirZaets I have applied the changes
Hi @VladimirZaets, thank you for the review. |
… side of search keyword in mobile magento#22795
Hi @sanjaychouhan-webkul, thank you for your contribution! |
Description (*)
For mobile view when search is focused I have set with only found solution https://www.google.com/search?q=jquery+set+cursor+at+end+of+input
Fixed Issues (if relevant)
Cursor position not in right side of search keyword in search box when click on search again (Mobile issue)
Manual testing scenarios (*)
Contribution checklist (*)