Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] fixed issue #22736 - Cursor position not in right side of search keyword in mobile #23352

Merged

Conversation

krishprakash
Copy link

@krishprakash krishprakash commented Jun 21, 2019

Original Pull Request

#22795

Description (*)

For mobile view when search is focused I have set with only found solution https://www.google.com/search?q=jquery+set+cursor+at+end+of+input

Fixed Issues (if relevant)

  1. Cursor position not in right side of search keyword in search box when click on search again (Mobile issue) #22736:
    Cursor position not in right side of search keyword in search box when click on search again (Mobile issue)

Manual testing scenarios (*)

  1. Load website in mobile view
  2. Search anything.
  3. Click on search icon to focus search box
  4. Check the cursor position

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@krishprakash
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your new Magento instance.
Admin access: https://pr-23352.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@krishprakash
Copy link
Author

Issue fixed in given 2.2 instance.

@ghost ghost assigned sidolov Jun 21, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 21, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5336 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA Passed

@magento-engcom-team magento-engcom-team merged commit 2464b31 into magento:2.2-develop Jun 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 26, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Search Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants