Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #22736 - Cursor position not in right side of search keyword in mobile #22795

Merged
merged 4 commits into from
May 23, 2019
Merged

fixed issue #22736 - Cursor position not in right side of search keyword in mobile #22795

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5621c44
fixed issue #22736 - Cursor position not in right side of search keyw…
May 8, 2019
3ca7c02
changed according to guidelines
May 18, 2019
3c8dcea
Update form-mini.js
VladimirZaets May 20, 2019
c79e1ff
magento/magento2#22795: Static test fix.
p-bystritsky May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/code/Magento/Search/view/frontend/web/js/form-mini.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ define([

if (this.isExpandable) {
this.element.attr('aria-expanded', isActive);
let searchValue = this.element.val();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sanjaychouhan-webkul.
Currently, we support only ES5 syntax, so can you please change let to var and according to our technical guidelines variables declaration should be on the top of the function.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladimirZaets I have applied the changes

this.element.val("");
this.element.val(searchValue);
}
},

Expand Down