Merge upstream #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d state (#319) In the GraphQL implementation we expose the cart validation result if the ValidateCart state fails. This information is missing in the JSON API so that you only see that the cart is invalid but not which rule was triggered. This PR therefore adds an additional field to the place order context when it's in failed state due to an invalid cart.
The split adds the moving cents to the first ones, resulting in having the smallest prices at the end but since discounts are negative, we need to reverse it to ensure that a split of the row totals has the rounding cents at the same positions Co-authored-by: Carsten Dietrich <[email protected]>
Currently, all our web APIs expose the prices not rounded, this leads to rounding implementations in the consumer. To avoid this we round all prices by default when requested as JSON.
* Update Readme.md
…_Price` (#325) Co-authored-by: Kai Kuhlmann <[email protected]> Co-authored-by: Nicole Schmelzer <[email protected]> Co-authored-by: Carsten Dietrich <[email protected]>
more logical calculation behavior on delivery level including shipping, shipping taxes and shipping discounts to the overall sums
…ues (#330) If the payment provider enforces an early place order and the payment is then aborted we never renew the order id.
Co-authored-by: Thorsten Essig <[email protected]>
Co-authored-by: Thorsten Essig <[email protected]>
Co-authored-by: Thorsten Essig <[email protected]>
* Bump flamingo.me/graphql to v1.5.0 * Force go 1.17
Co-authored-by: nicole.schmelzer <[email protected]> Co-authored-by: Carsten Dietrich <[email protected]>
Now using fixed versions to avoid polluting the go.sum/go.mod
* price: fix rounding of negative values when using RoundingModeHalfUp / RoundingModeHalfDown * price: update test to be inline with Java/PHP half down / half up Co-authored-by: Christopher Schwab <[email protected]> Co-authored-by: Thorsten Essig <[email protected]>
* Prepare changelog for release v3.5.0
Co-authored-by: Christopher Schwab <[email protected]>
By moving calculation responsibility, we enable different implementation possibilities for calculations like tax before or after discounts, tax on single item or sum and different tax rounding modes instead of having it hard-coded in the flamingo cart. Co-authored-by: Carsten Dietrich <[email protected]>
…iggerClientSDK` (#349)
Co-authored-by: nicole.schmelzer <[email protected]>
* add unitCode to variant selections * Fix unit tests * regenerated + updated changelog * fix mapping of variation selections Co-authored-by: nicole.schmelzer <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…uring place order (#590) * feat(checkout/orderservice): Introduce flag to skip cart validation during place order * chore: fix linter, bump golangci-lint to latest version
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.0.3+incompatible to 27.1.0+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v27.0.3...v27.1.0) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(product): add sorting options * fix(product): fix tests * feat(product): give promotion with empty fields, when there are hits * fix(product): review fixes * fix(product): update changelog * fix(product): review fixes
* chore: Replace github.com/pkg/errors with Go core error package * chore: switch to non dynamic errors that already exist
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(product): extend fake search with default value * chore: remove loop braking after first sort filter
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.1.0+incompatible to 27.1.1+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v27.1.0...v27.1.1) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#543) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…o to v0.33.0 (#602) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat(271627): expose bundle configuration via method --------- Co-authored-by: Kirill Grigorev <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…o to v0.34.0 (#619) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.25.0 to 0.31.0. - [Commits](golang/crypto@v0.25.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#618) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…613) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.